Conversation
akashsonune
commented
Feb 10, 2026
akashsonune
commented
- I confirm that this MR follows the contribution guidelines.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the missingTranslateMigrationRule from the v47to48Migration. This removal is concerning as it could lead to incomplete project migrations for users, potentially causing runtime issues with internationalization. The existing review comment highlights this potential regression and suggests restoring the rule, and it has been retained as it is valid and does not contradict any provided rules.
| return chain([ | ||
| elementMigrationRule({ ...options }, migrationData), | ||
| missingTranslateMigrationRule(options) | ||
| elementMigrationRule({ ...options }, migrationData) |
There was a problem hiding this comment.
The missingTranslateMigrationRule is being removed from the v47to48Migration, but it is still present in the v48to49Migration. This inconsistency suggests that removing it here might be a mistake. This rule handles important updates to ngx-translate configuration, and its absence could lead to runtime translation issues in applications that are upgraded to v48. This change introduces a potential regression.
elementMigrationRule({ ...options }, migrationData),
missingTranslateMigrationRule(options)1 participant
